Modernize tsconfig.json for Node.js module resolution#1528
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the repository’s TypeScript configuration to use modern Node.js-aware module settings (nodenext) and aligns the type test suite with the updated compilation behavior.
Changes:
- Switched
tsconfig.jsonto"module"/"moduleResolution": "nodenext"and bumped the compilation target/lib to ES2022. - Explicitly included Node.js ambient types in
tsconfig.json. - Adjusted the
Ratetype test to avoid top-levelawaitand to assert both the promised and awaitedcreateRate()types.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tsconfig.json | Modernizes TS compiler settings for Node.js module resolution and ES2022 baseline. |
| test/types/index.test-d.ts | Updates type assertions around createRate() and avoids top-level await in the type test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moduleandmoduleResolutiontonodenextto align with modern Node.js library publishing and ES module resolution semantics.targetandlibtoes2022. The project's existingenginesfloor (node >= 20.20.2) guarantees full ES2022 runtime support, so targeting es2022 is safe and lets type-checking reflect modern language features instead of nodenext's floatingtarget: esnext."types": ["node"]so rawtsc --noEmitresolves Node globals (Buffer, setTimeout, child_process, events, AbortSignal) without relying on tsd's implicit @types/node injection.awaitin test/types/index.test-d.ts into an async IIFE, since nodenext classifies the file as CommonJS where top-level await is illegal.Strict Type-Checking Options,Additional Checks) carried over from the original generated tsconfig template.Fix: #1527