Use aysnc method to grab the version of generator#187
Merged
minggangw merged 1 commit intoRobotWebTools:developfrom Nov 21, 2017
Merged
Use aysnc method to grab the version of generator#187minggangw merged 1 commit intoRobotWebTools:developfrom
minggangw merged 1 commit intoRobotWebTools:developfrom
Conversation
To combine with JavaScript convention, we should read a file asynchronously in order not to block the thread, which can be achieved by using the async version of readFile. Also, this patch fixed a bug caused by 5d764f5. Fix RobotWebTools#183
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To combine with JavaScript convention, we should read a file
asynchronously in order not to block the thread, which can be
achieved by using the async version of readFile.
Also, this patch fixed a bug caused by 5d764f5.
Fix #183