Fix issues when using parameters of type array #855
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
This PR fixes the following issues with parameters when the parameter type is an array. (in order of commits)
PARAMETER_STRING_ARRAYwas not handled everywherePARAMETER_[BYTE/INTEGER/DOUBLE]_ARRAYare of typeTypedArraywhich throws aTypeError('incompatible value')in thevalidate()method. This is because_validArray()(more specificallyArray.isArray()returnsfalsewhen given aTypedArrayarrayElementTypeofPARAMETER_BYTE_ARRAYwas set toPARAMETER_BYTEwhich is a type that does not exist (undefined). We can usePARAMETER_INTEGERinstead.Unit tests were added to reproduce the bugs, then the next commits fix those bugs.