Port TFClient impls to TypeScript #1009
Conversation
EzraBrooks
force-pushed
the
port-tfclients-to-typescript
branch
2 times, most recently
from
c27a53c to
8d1e1b8
Compare
| transThres?: number; | ||
| rate?: number; | ||
| updateDelay?: number; | ||
| topicTimeout?: number; |
There was a problem hiding this comment.
preceded this PR, but topicTimeout should really be serviceTimeout ... however, not worth breaking anything for this i guess.
There was a problem hiding this comment.
Preceded this PR by many years I think!!
| @@ -0,0 +1,22 @@ | |||
| export namespace geometry_msgs { | |||
| export interface TransformStamped { | |||
| // TODO: some sort of unholy union type of ros1 header and ros2 header??? | |||
There was a problem hiding this comment.
ros 1 is deprecated, so I'd just not bother and point people to use older versions of this library if they need ros 1
There was a problem hiding this comment.
Agreed in theory, but at that point why not rip out the entire ROS 1 implementation of TFClient?
| x: number; | ||
| y: number; | ||
| z: number; | ||
| w: number; |
There was a problem hiding this comment.
minor point, but in the ROS 2 message definition, the w field actually defaults to 1.0, whereas all the other scalar numeric fields default to 0.0. Is that something we can/should do here too?
There was a problem hiding this comment.
interfaces can't be instantiated, so you can't set defaults
| rate: number; | ||
| } | ||
|
|
||
| export type TFSubscriptionResult = Record<never, never>; |
There was a problem hiding this comment.
what does it mean that this one is type vs the others being interface?
There was a problem hiding this comment.
type lets me use type expressions, like the assignment I'm doing here. interface only allows describing an object type as a block of fields in curly braces
EzraBrooks
force-pushed
the
port-tfclients-to-typescript
branch
from
8d1e1b8 to
8ff4176
Compare
EzraBrooks
force-pushed
the
port-tfclients-to-typescript
branch
from
8ff4176 to
22e6300
Compare
sea-bass
left a comment
sea-bass
left a comment
There was a problem hiding this comment.
I think all my initial comments are eh, let's do it
Lots of hand-written message types here.. need to figure out a way to automate
ros-typescript-generatorusing the Docker container I built for the integration tests