Stop bundling dependencies, UMD file #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EzraBrooks
force-pushed
the
stop-bundling-dependencies
branch
from
e6d48cb to
a7f15ba
Compare
Collaborator
Author
|
We've already been forcing all our package-manager-using users to download all our dependencies, and then we weren't actually using them. This PR takes our compiled library size down from over 300kB to less than 70kB. As I mentioned in #1056, CDN users (however many of them will actually migrate to 2.0, given that CDN-based JS usage is pretty old-fashioned) will just need to set up an import map - which is not unlike how we used to tell users to grab EventEmitter from a CDN in addition to grabbing roslibjs. |
Allow users' package managers to satisfy our dependencies, instead of bundling them all in our compiled output. (this is like dynamic linking as opposed to static linking for JS)
EzraBrooks
force-pushed
the
stop-bundling-dependencies
branch
from
a7f15ba to
d80b3f0
Compare
Member
|
@Krzemien97 Does this affect us in any way? |
Collaborator
Author
|
As long as you guys are installing via a package manager like npm, pnpm, yarn, etc. and are using an ESM-compatible build tool (basically all of them at this point), it shouldn't. |
bjsowa
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users' package managers to satisfy our dependencies, instead of bundling them all in our compiled output.
(this is like dynamic linking as opposed to static linking for JS)
As an aside, the question now becomes "why use a bundler like Vite at all now when we're not really 'bundling' anything?". Why indeed? I ported us to Vite to replace a bunch of old tooling, but maybe we don't even need Vite in the long term since the JavaScript module-importing ecosystem is far more mature than it once was.