Skip to content

use callFromThread#84

Merged
beverlylytle merged 2 commits intomainfrom
callFromThread
May 14, 2021
Merged

use callFromThread#84
beverlylytle merged 2 commits intomainfrom
callFromThread

Conversation

@beverlylytle
Copy link
Copy Markdown
Contributor

@beverlylytle beverlylytle commented May 14, 2021

All of the Twisted API needs to be called from the thread running the reactor. If not, weird blocking issues may occur. These blocking issues are made apparent when running multiple calls that use compas.await_callback (or really anything that has a callback which invokes event.set and waiting on that event in what may or may not be another thread) in cpython on mac.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke check).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@beverlylytle beverlylytle requested a review from gonzalocasas May 14, 2021 09:40
@gonzalocasas
Copy link
Copy Markdown
Contributor

LGTM! Also tested on Windows.

@beverlylytle beverlylytle merged commit 95c4a46 into main May 14, 2021
@beverlylytle beverlylytle deleted the callFromThread branch May 14, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants