Skip to content

Conversation

@lchojnack
Copy link

No description provided.

Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
@lchojnack lchojnack requested a review from dmoszynski August 17, 2023 14:44
Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
![select ego transform 2](select_ego_transform_2.gif)
![select ego transform 3](select_ego_transform_3.png)

## 3. Configure
Copy link

@dmoszynski dmoszynski Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should rather be in the UserGuide, I encourage you to add Components->V2I a description of what it is, what it is responsible for, what it consists of. (take a look as described in other sections and try to fit in - for example here)
In the description of Environment it would also be worth adding that it contains V2I.


If for some reason, `Traffic Light Lanelet ID` component is not added to `Traffic Light` object.

### 1. Add component manually

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

higher is 1. here ### 1. - better 1. also and short description.

@@ -0,0 +1,23 @@
# Assign Lanelet2 WayID and RelationID to TrafficLight object
Copy link

@dmoszynski dmoszynski Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think the whole chapter should be called Add V2I and it shouldn't be divided into 2 pages but everything should be here in 3 or more sections (because they don't seem to be long and, in addition, they are rather dependent on each other)

ps. it should be clear to the reader what is needed to work and why (I encourage you to describe it in the UserGuide)

Copy link

@dmoszynski dmoszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants