-
Notifications
You must be signed in to change notification settings - Fork 0
Add V2I feature documentation #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: docs-update
Are you sure you want to change the base?
Conversation
Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
|  | ||
|  | ||
|
|
||
| ## 3. Configure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should rather be in the UserGuide, I encourage you to add Components->V2I a description of what it is, what it is responsible for, what it consists of. (take a look as described in other sections and try to fit in - for example here)
In the description of Environment it would also be worth adding that it contains V2I.
|
|
||
| If for some reason, `Traffic Light Lanelet ID` component is not added to `Traffic Light` object. | ||
|
|
||
| ### 1. Add component manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
higher is 1. here ### 1. - better 1. also and short description.
| @@ -0,0 +1,23 @@ | |||
| # Assign Lanelet2 WayID and RelationID to TrafficLight object | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I think the whole chapter should be called Add V2I and it shouldn't be divided into 2 pages but everything should be here in 3 or more sections (because they don't seem to be long and, in addition, they are rather dependent on each other)
ps. it should be clear to the reader what is needed to work and why (I encourage you to describe it in the UserGuide)
dmoszynski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the comments.
No description provided.