Improve Code Coverage and Fix Bugs #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoschenkel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of signalClass parameter now is
IClass<ISignal>, that means you can only map and unmap a concrete reference for a Signal class or some class that is extending the Signal class.The CommandExecutor now is able to remove a mapping because the removeMapping function is passed using the bind method to solve the reference for this element.
All original unit tests from the AS3 implementation are now migrated and are working as expected, ensuring that this TypeScript version is keeping the same behavior. Take a look inside the test folder to see different ways of using the ISignalCommandMap service.