Merged
Conversation
Extends simplenamespace and uses it in tests
helrond
reviewed
Mar 12, 2026
Member
helrond
left a comment
helrond
left a comment
There was a problem hiding this comment.
I'm seeing the object to convert being passed in two ways:
- as a dictionary
- as an exploded dictionary
**{"foo": "bar"}, which results in kwargs likefoo=bar
I think we could just pass them all as dictionaries - it's a little cleaner
Use regular dicts for RecursiveNamespace
helrond
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends simplenamespace and uses it in tests
Wanted to make a separate PR so we could see the diffs better.