fix: data directory creation by uncommenting mkdirSync in Codebase class #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogesh-aggarwal
force-pushed
the
fix/data-directory
branch
from
d3af16f to
9c44913
Compare
Contributor
Author
|
Hey @preeesha I have made the necessary changes to fix this issue. Kindly review this once and let me know if you need any sort of insight or clarification. |
…ization logic and ensure proper directory creation
Collaborator
|
Looks good to me! Merging it now. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
This pull request includes a change to the
initializeDataDirectorymethod in theCodebaseclass to ensure the data directory name is always generated usinguuid.ingestion/src/process/prepare/codebase.ts: Modified theinitializeDataDirectorymethod to always useuuidfor generating_dataDirNameand uncommented themkdirSynccall to ensure the data directory is created.