BUG: Message history fails to load

[Aryan-Verma-999]

Description:

EmbeddedChat has stopped loading previous messages after the recent merges.

The client ends up calling the private room history endpoint for a public room. For example, for the public room GENERAL, it sends:

GET /api/v1/groups.messages?roomId=GENERAL

That returns 400 Bad Request, and the chat history does not load.

Steps to reproduce:

1. Run EmbeddedChat/Storybook against a Rocket.Chat workspace that has a public room like GENERAL and at least one private room.
2. Open a story and join any public room.
3. Check the network tab and the chat history loading behavior.

Expected behavior:

EmbeddedChat should detect the active room type correctly and use the matching endpoint every time.

For a public room like GENERAL, it should call:

GET /api/v1/channels.messages?roomId=GENERAL

Previous messages should load normally.

Actual behavior:

EmbeddedChat calls:

GET /api/v1/groups.messages?roomId=GENERAL

That request returns 400 Bad Request, and previous messages/chat history do not load.

Screenshot

[Aryan-Verma-999]

working on this

[Aryan-Verma-999]

@Spiral-Memory

[sudorishabh]

Hey @Aryan-Verma-999 , Are you working on this issue? It seems like you opened a PR for a different issue.

I would be happy to discuss the issue.

I think the root cause of this issue is that isChannelPrivate is stored in the global Zustand store and is only ever set to true when we encounter a private room (t === 'p'). But we never reset it back to false when switching to a public room.

So if a user or Storybook opens a private room once, that flag stays true. Then when we switch to a public room like GENERAL (t === 'c'), we don’t update it, and it keeps using groups endpoints instead of channels, which leads to 400 errors and no message history. Also, even though a new RCInstance is created when roomId changes, the store isn’t reset, so this stale value carries over between rooms.

We should always derive isChannelPrivate from the current room instead of setting it conditionally. Something like:

setIsChannelPrivate(res.room.t === 'p')

This ensures it’s always correct for the active room.

It’d also be good to apply the same pattern to other room-scoped flags (like isRoomTeam) so they don’t persist across room switches.

[Aryan-Verma-999]

Hey, thanks for diving into this
youre completely correct about the root cause.
i just opened a pr for this feel free to check it out and let me know if you have any thoughts