Intial logic for tooltip label position#1087
Merged
Spiral-Memory merged 1 commit intoRocketChat:developfrom Mar 21, 2026
Merged
Intial logic for tooltip label position#1087Spiral-Memory merged 1 commit intoRocketChat:developfrom
Spiral-Memory merged 1 commit intoRocketChat:developfrom
Conversation
Collaborator
|
I recall there was a specific reason for doing it that way, could you create a video showcasing all the other variations, demonstrating the before-and-after effects on both sides, especially when hovering over top and bottom messages? |
Contributor
Author
|
Sure below I have attached the demos: Curve Variant:BEFORE: before-Colourful-aqua.mp4After: 2026-03-13.15-31-00.mp4 |
Contributor
Author
Modern Variant:Before: 2026-03-13.15-34-44.mp4After : 2026-03-13.15-35-49.mp4 |
Contributor
Author
|
There is one more variant called "RC variant " and the results were the same as the previous variants. Please let me know if the demo video is what you expected. If not I can send it as needed. |
Spiral-Memory
approved these changes
Mar 21, 2026
Collaborator
Spiral-Memory
left a comment
There was a problem hiding this comment.
Looks good. Appreciate the time and effort you put into creating those detailed videos, it’s really helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Title
This PR helps with fixing the inconsistent behavior of the message tooltip.
Acceptance Criteria fulfillment
Fixes #1086
Video/Screenshots
topLabelsTooltip.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace
<pr_number>with the actual PR number.