Skip to content

Intial logic for tooltip label position#1087

Merged
Spiral-Memory merged 1 commit intoRocketChat:developfrom
Pratheek555:fix/Inconsistent_Labels_Tooltip
Mar 21, 2026
Merged

Intial logic for tooltip label position#1087
Spiral-Memory merged 1 commit intoRocketChat:developfrom
Pratheek555:fix/Inconsistent_Labels_Tooltip

Conversation

@Pratheek555
Copy link
Copy Markdown
Contributor

@Pratheek555 Pratheek555 commented Jan 19, 2026

Brief Title

This PR helps with fixing the inconsistent behavior of the message tooltip.

Acceptance Criteria fulfillment

  • Fixes the inconsistent behavior of message tooltip labels

Fixes #1086

Video/Screenshots

topLabelsTooltip.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Copy Markdown
Collaborator

I recall there was a specific reason for doing it that way, could you create a video showcasing all the other variations, demonstrating the before-and-after effects on both sides, especially when hovering over top and bottom messages?

@Spiral-Memory Spiral-Memory added question Further information is requested nudge minor tweaks suggested labels Mar 13, 2026
@Pratheek555
Copy link
Copy Markdown
Contributor Author

Sure below I have attached the demos:

Curve Variant:

BEFORE:

before-Colourful-aqua.mp4

After:

2026-03-13.15-31-00.mp4

@Pratheek555
Copy link
Copy Markdown
Contributor Author

Modern Variant:

Before:

2026-03-13.15-34-44.mp4

After :

2026-03-13.15-35-49.mp4

@Pratheek555
Copy link
Copy Markdown
Contributor Author

There is one more variant called "RC variant " and the results were the same as the previous variants.

Please let me know if the demo video is what you expected. If not I can send it as needed.

@Spiral-Memory Spiral-Memory added chore a subtle fix and removed question Further information is requested nudge minor tweaks suggested labels Mar 21, 2026
Copy link
Copy Markdown
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Appreciate the time and effort you put into creating those detailed videos, it’s really helpful.

@Spiral-Memory Spiral-Memory merged commit 7734fd0 into RocketChat:develop Mar 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a subtle fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: Inconsistent display of tooltip

2 participants