fix: remove dangerous busy-wait lock in handleTypingEvent causing DoS#1130
Open
deepak0x wants to merge 2 commits intoRocketChat:developfrom
Open
fix: remove dangerous busy-wait lock in handleTypingEvent causing DoS#1130deepak0x wants to merge 2 commits intoRocketChat:developfrom
deepak0x wants to merge 2 commits intoRocketChat:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical Denial of Service (DoS) vulnerability caused by a busy-wait infinite loop in
handleTypingEvent, which could permanently freeze the UI or Node.js process.What I did in thie code
Removed dangerous busy-wait loop
while (typingHandlerLock) {}which blocked the JavaScript main thread.Removed redundant manual locking logic
typingHandlerLockand the relatedsetTimeout-based reset mechanism.Safe sequential processing
Resilience to internal errors
Closes #1129
Behavior Comparison