Skip to content

Fix: emoji picker toggles reactions consistently with message clicks #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohitbansal2005 wants to merge 1 commit into
base: develop
Choose a base branch
from
+7 −2
Open

Fix: emoji picker toggles reactions consistently with message clicks #1246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react/src/lib/reaction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ export const serializeReactions = (reactions) => {
};

export const isSameUser = (reaction, username) =>

reaction.usernames.find((u) => u === username);
8 changes: 6 additions & 2 deletions packages/react/src/views/Message/Message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,13 @@ const Message = ({
getStarredMessages();
};

const handleEmojiClick = async (e, msg, canReact) => {
const handleEmojiClick = async (e, msg, _canReact) => {
const emoji = (e.names?.[0] || e.name).replace(/\s/g, '_');
await RCInstance.reactToMessage(emoji, msg._id, canReact);
const reactionKeysToCheck = emoji?.startsWith(':') ? [emoji] : [emoji, `:${emoji}:`];
const alreadyReacted = reactionKeysToCheck.some((key) =>
msg?.reactions?.[key]?.usernames?.includes(authenticatedUserUsername)
);
await RCInstance.reactToMessage(emoji, msg._id, !alreadyReacted);
};

const handleOpenThread = (msg) => async () => {
Expand Down