feat: Enhance video recorder#831
Merged
Spiral-Memory merged 6 commits intoJan 15, 2026
Merged
Conversation
Collaborator
|
Do we really need this much code changes for this ? |
Contributor
Author
Yes, I have written a new function in 'useMediaRecorder.js'. The earlier functions were not supporting the current functionality I implemented. I wanted to completely remove those old functions, but currently, they are still used to record audio messages in 'AudioMessageRecorder.js'. Maybe after this PR gets merged, I will use the new function I wrote in this PR to record audio messages as well. |
2ef2985 to
8f3bb40
Compare
Collaborator
|
@dhairyashiil |
Contributor
Author
Done. Resolved the merge conflict. |
Collaborator
|
Still there |
Contributor
Author
Hello @Spiral-Memory , Resolved. Please check |
Spiral-Memory
approved these changes
May 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Title
Acceptance Criteria fulfillment
Fixes #830
Video/Screenshots
Enhance.video.recorder.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-831 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.