Skip to content

feat: Enhance video recorder#831

Merged
Spiral-Memory merged 6 commits into
RocketChat:developfrom
dhairyashiil:feat/enhance-video-recorder
Jan 15, 2026
Merged

feat: Enhance video recorder#831
Spiral-Memory merged 6 commits into
RocketChat:developfrom
dhairyashiil:feat/enhance-video-recorder

Conversation

@dhairyashiil
Copy link
Copy Markdown
Contributor

Brief Title

Acceptance Criteria fulfillment

  • Make transitions smoother for starting, stopping, and sending the video, so users have a better flow when using the recorder.
  • Update the interface with buttons for starting, stopping, and sending the video. The send button should be disabled until there’s a recording to send.
  • Buttons change color according to the theme (light/dark mode).

Fixes #830

Video/Screenshots

Enhance.video.recorder.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-831 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Copy Markdown
Collaborator

Do we really need this much code changes for this ?

@dhairyashiil
Copy link
Copy Markdown
Contributor Author

Do we really need this much code changes for this ?

Yes, I have written a new function in 'useMediaRecorder.js'. The earlier functions were not supporting the current functionality I implemented. I wanted to completely remove those old functions, but currently, they are still used to record audio messages in 'AudioMessageRecorder.js'. Maybe after this PR gets merged, I will use the new function I wrote in this PR to record audio messages as well.

@Spiral-Memory
Copy link
Copy Markdown
Collaborator

@dhairyashiil
Resolve the conflicts

@Spiral-Memory Spiral-Memory added the nudge minor tweaks suggested label Jan 27, 2025
@dhairyashiil
Copy link
Copy Markdown
Contributor Author

@dhairyashiil Resolve the conflicts

Done. Resolved the merge conflict.

@Spiral-Memory
Copy link
Copy Markdown
Collaborator

Still there

@dhairyashiil
Copy link
Copy Markdown
Contributor Author

Still there

Hello @Spiral-Memory , Resolved. Please check

@dhairyashiil dhairyashiil changed the title Enhance video recorder feat: Enhance video recorder Mar 31, 2025
@Spiral-Memory Spiral-Memory added testing and removed nudge minor tweaks suggested labels May 24, 2025
@Spiral-Memory Spiral-Memory merged commit 7a241ab into RocketChat:develop Jan 15, 2026
4 checks passed
github-actions Bot added a commit that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: Enhance Video Recorder

2 participants