Fix: Include pinned messages from threads in the main chat interface#854
Closed
smritidoneria wants to merge 9 commits intoRocketChat:developfrom
Closed
Fix: Include pinned messages from threads in the main chat interface#854smritidoneria wants to merge 9 commits intoRocketChat:developfrom
smritidoneria wants to merge 9 commits intoRocketChat:developfrom
Conversation
| const sortedMessages = messages.sort( | ||
| (a, b) => new Date(b.ts) - new Date(a.ts) | ||
| ); | ||
| console.log(sortedMessages); |
Contributor
Author
|
Done |
Spiral-Memory
approved these changes
Jan 11, 2025
Spiral-Memory
force-pushed
the
develop
branch
from
2ef2985 to
8f3bb40
Compare
| return; | ||
| } | ||
| const { messages } = await RCInstance.getPinnedMessages(); | ||
| const sortedMessages = messages.sort( |
Collaborator
There was a problem hiding this comment.
Do we need sorting, if messages are lot, this will take time right ?
Contributor
Author
|
Sorting can be time-consuming if there are a large number of pinned messages. However, to maintain consistency with Rocket.Chat, I have implemented sorting since pinned messages in Rocket.Chat are sorted. Alternatively, we have two other approaches: Implement pagination to fetch messages dynamically as the user scrolls to the bottom of the interface, ensuring only the required messages are loaded. |
Contributor
Author
|
hey @Spiral-Memory , can you please take a look at this and let me know which approach would be suitable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Title
This pull request addresses the issue where pinned messages in threads do not appear in the main chat interface. The solution involves fetching pinned messages from both the main chat and threads and combining them to ensure they are all displayed in the main chat interface.
Fixes #853
Video/Screenshots
Screen.Recording.2025-01-09.at.9.46.00.PM.mov
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace
<pr_number>with the actual PR number.