This repository was archived by the owner on Oct 30, 2025. It is now read-only.
[NEW] Notifications for new messages and rooms#91
Merged
murtaza98 merged 8 commits intoRocketChat:developfrom Mar 15, 2021
Merged
[NEW] Notifications for new messages and rooms#91murtaza98 merged 8 commits intoRocketChat:developfrom
murtaza98 merged 8 commits intoRocketChat:developfrom
Conversation
dhruvjain99
force-pushed
the
ftr-notification
branch
from
be49981 to
40326a9
Compare
- Events do not emit if iframe is not loaded - Load iframe in home - Fix add room when sorting is enabled
dhruvjain99
force-pushed
the
ftr-notification
branch
from
750d7db to
ad987dc
Compare
RonLek
suggested changes
Mar 14, 2021
RonLek
approved these changes
Mar 14, 2021
Contributor
RonLek
left a comment
RonLek
left a comment
There was a problem hiding this comment.
LGTM! @Sing-Li @murtaza98 we can merge this one in.
murtaza98
approved these changes
Mar 15, 2021
This was referenced Mar 15, 2021
Closed
Closed
dhruvjain99
changed the title
dhruvjain99
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screencast.from.11-03-21.07.56.06.PM.IST.mp4
Fixes #61, #88, #83, #84