This repository was archived by the owner on Oct 30, 2025. It is now read-only.
[FIX] Migrate Github oauth to Github apps#99
Merged
murtaza98 merged 6 commits intoRocketChat:developfrom Mar 15, 2021
Merged
Conversation
dhruvjain99
force-pushed
the
fine-grained-access
branch
2 times, most recently
from
3f28906 to
7786521
Compare
- Add warning note on public room creation for private repo - Fix two room items displayed for same room in sidebar on creating a new room - Add Github app slug constant - Fix check users for private room on fetching webhook id - Move roomMembers and create room to one controller
dhruvjain99
force-pushed
the
fine-grained-access
branch
from
7786521 to
93f59cb
Compare
RonLek
force-pushed
the
fine-grained-access
branch
from
93f59cb to
9f001c3
Compare
dhruvjain99
force-pushed
the
fine-grained-access
branch
2 times, most recently
from
14875e2 to
93f59cb
Compare
RonLek
approved these changes
Mar 15, 2021
Contributor
RonLek
left a comment
RonLek
left a comment
There was a problem hiding this comment.
@Sing-Li @murtaza98 we can merge this PR in.
murtaza98
approved these changes
Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94