fix: preference value changes causing reset to other option#7313
Conversation
WalkthroughThe PR updates two preference toggle handlers to merge updated fields into the existing ChangesPreference Handlers State Preservation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
diegolmello
left a comment
There was a problem hiding this comment.
Almost there. Just show your attachments properly on PR description.
Proposed changes
In Preferences, enabling Mobile Ringing was unintentionally disabling the Convert ASCII to Emoji setting.
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-2186
How to test or reproduce
Screenshots
Before
Screen.Recording.2026-05-08.at.10.01.21.PM.mov
After
Screen.Recording.2026-05-08.at.10.00.46.PM.mov
Types of changes
Checklist
Further comments
Summary by CodeRabbit