[BUG] Hide login button when setting is disabled

[rafaelks]

@RocketChat/ios

[filipealva]

@rafaelks we could put the new line inside the if block. That way we would evaluate settings.isUsernameAuthenticationEnabled just once.

[rafaelks]

👍

[filipealva]

@rafaelks actually if isUsernameAuthenticationEnabled is false we shouldn't even show the emailAuthRow and neither the separator of the login services section

[rafaelks]

@filipealva Done!

[filipealva]

@rafaelks Nice! but just hiding the cell still let us considering its height on uitableview's content size, which means that if you have a server with a certain number of login services you'll have an issue with an extra offset

[rafaelks]

@filipealva I see... this is not using AutoLayout, so when the registerButton was hidden it was already having a white space. Will make some adjustments here.

[codecov]

Codecov Report

Merging #2049 into develop will increase coverage by 0.5%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           develop    #2049     +/-   ##
==========================================
+ Coverage    35.74%   36.24%   +0.5%     
==========================================
  Files          374      374             
  Lines        17432    17428      -4     
==========================================
+ Hits          6231     6317     +86     
+ Misses       11201    11111     -90

Impacted Files	Coverage Δ
...hat/Controllers/Auth/AuthTableViewController.swift	0% <0%> (ø)	⬆️
...at/Controllers/Base/BaseNavigationController.swift	42.5% <0%> (-12.5%)	⬇️
...at/Controllers/Auth/AuthNavigationController.swift	32.2% <0%> (-10.17%)	⬇️
...Views/Cells/Subscription/ChatPreviewModeView.swift	43.47% <0%> (-8.7%)	⬇️
...ket.Chat/Controllers/Base/BaseViewController.swift	79.48% <0%> (-5.13%)	⬇️
Rocket.Chat/Managers/AppManager.swift	62.61% <0%> (-0.47%)	⬇️
...Controllers/Auth/ConnectServerViewController.swift	64.03% <0%> (ø)	⬆️
...hat/Controllers/Base/MainSplitViewController.swift	86.04% <0%> (ø)	⬆️
...lers/Notification/NotificationViewController.swift	52.22% <0%> (ø)	⬆️
Rocket.Chat/Theme/ThemeableViews.swift	83.22% <0%> (+0.62%)	⬆️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec08e8...a5a8d0a. Read the comment docs.

[filipealva]

👍