This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[CHORE] Bouncing reactors & badge all the time for unreads#2051
Merged
filipealva merged 5 commits intodevelopfrom Jul 20, 2018
Merged
[CHORE] Bouncing reactors & badge all the time for unreads#2051filipealva merged 5 commits intodevelopfrom
filipealva merged 5 commits intodevelopfrom
Conversation
Contributor
|
A little description on the PR is good when there's no issue associated 🤓 About the bouncing: awesome! About the unread badge for all unread messages: I like the idea but the I tried letting the font |
Contributor
|
Just one more thing 🤓 we could increase the spacing between the label and the badge just a little bit. |
filipealva
approved these changes
Jul 20, 2018
Contributor
filipealva
left a comment
filipealva
left a comment
There was a problem hiding this comment.
I'm approving it since the spacing issue is not related to this PR it's just a suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios