This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[IMPROVEMENT] Use opaque cells for subscriptions table view#2053
Merged
rafaelks merged 1 commit intoRocketChat:developfrom Jul 20, 2018
Merged
[IMPROVEMENT] Use opaque cells for subscriptions table view#2053rafaelks merged 1 commit intoRocketChat:developfrom
rafaelks merged 1 commit intoRocketChat:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2053 +/- ##
===========================================
- Coverage 35.96% 35.68% -0.28%
===========================================
Files 374 374
Lines 17437 17436 -1
===========================================
- Hits 6271 6222 -49
- Misses 11166 11214 +48
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Currently, the table view cells for
SubscriptionsViewControllerhave a transparent background when they are selected. This causes the cells to flicker when they are reloaded.This will solve the flickering issue, without the need of
UIView.performWithoutAnimation, which may also be responsible for a crash we recently started experiencing.Possibly Closes #2036
This issue can be closed after beta testing, or a public release, if the crash no longer occurs.