Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

[IMPROVEMENT] Use opaque cells for subscriptions table view#2053

Merged
rafaelks merged 1 commit intoRocketChat:developfrom
Sameesunkaria:2036-use-opaque-cells
Jul 20, 2018
Merged

[IMPROVEMENT] Use opaque cells for subscriptions table view#2053
rafaelks merged 1 commit intoRocketChat:developfrom
Sameesunkaria:2036-use-opaque-cells

Conversation

@Sameesunkaria
Copy link
Copy Markdown
Contributor

@RocketChat/ios

Currently, the table view cells for SubscriptionsViewController have a transparent background when they are selected. This causes the cells to flicker when they are reloaded.

This will solve the flickering issue, without the need of UIView.performWithoutAnimation, which may also be responsible for a crash we recently started experiencing.

Possibly Closes #2036
This issue can be closed after beta testing, or a public release, if the crash no longer occurs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 20, 2018

Codecov Report

Merging #2053 into develop will decrease coverage by 0.27%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2053      +/-   ##
===========================================
- Coverage    35.96%   35.68%   -0.28%     
===========================================
  Files          374      374              
  Lines        17437    17436       -1     
===========================================
- Hits          6271     6222      -49     
- Misses       11166    11214      +48
Impacted Files Coverage Δ
...ubscriptionsList/SubscriptionsViewController.swift 39.23% <0%> (+0.37%) ⬆️
...iews/Cells/Subscription/BaseSubscriptionCell.swift 0% <0%> (ø) ⬆️
Rocket.Chat/API/Clients/PushClient.swift 0% <0%> (-33.34%) ⬇️
...Chat/Managers/Socket/Response/SocketHandlers.swift 38.63% <0%> (-25%) ⬇️
...Managers/Model/AuthManager/AuthManagerSocket.swift 12.82% <0%> (-14.75%) ⬇️
...et.Chat/Managers/Socket/Response/SocketError.swift 93.33% <0%> (-6.67%) ⬇️
...lers/Notification/NotificationViewController.swift 52.22% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0963d7e...853e677. Read the comment docs.

@Sameesunkaria Sameesunkaria requested a review from rafaelks July 20, 2018 20:58
Copy link
Copy Markdown
Contributor

@rafaelks rafaelks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good finding!!! :-)

@rafaelks rafaelks merged commit a3d313d into RocketChat:develop Jul 20, 2018
@Sameesunkaria Sameesunkaria deleted the 2036-use-opaque-cells branch August 31, 2018 12:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CRASH] SubscriptionsViewController.swift line 89 SubscriptionsViewController.viewDidLoad() -> () empty-

2 participants