Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@filipealva
Copy link
Contributor

@filipealva filipealva commented Oct 1, 2018

@RocketChat/ios

It requires this PR merged

Also the animation doesn't feels good. I think removing the cell's background will help, but we maybe will have to implement a custom animation for this one, I'll leave it to do after, when applying themes and the missing appearance traits.

@rafaelks rafaelks added this to the 3.2.0 milestone Oct 1, 2018
@codecov
Copy link

codecov bot commented Oct 2, 2018

Codecov Report

Merging #2227 into feature/integrate-rc-view-controller will decrease coverage by 0.36%.
The diff coverage is 0.97%.

Impacted file tree graph

@@                           Coverage Diff                            @@
##           feature/integrate-rc-view-controller    #2227      +/-   ##
========================================================================
- Coverage                                 27.92%   27.55%   -0.37%     
========================================================================
  Files                                       407      409       +2     
  Lines                                     15243    15338      +95     
========================================================================
- Hits                                       4257     4227      -30     
- Misses                                    10986    11111     +125
Impacted Files Coverage Δ
....Chat/Controllers/Chat/MessagesSizingManager.swift 75% <0%> (-25%) ⬇️
...at/New Chat/ChatItems/TextAttachmentChatItem.swift 0% <0%> (ø)
...et.Chat/Views/Cells/Chat/ChatMessageTextView.swift 0% <0%> (ø) ⬆️
...Views/Chat/New Chat/Cells/TextAttachmentCell.swift 0% <0%> (ø)
...Controllers/Chat/ChatSections/MessageSection.swift 1.77% <0%> (-0.04%) ⬇️
...llers/Chat/ChatControllerMessageCellProtocol.swift 0% <0%> (ø) ⬆️
...Chat/Controllers/Chat/MessagesViewController.swift 51.11% <100%> (+1.11%) ⬆️
...anagers/Model/AuthManager/AuthManagerRecover.swift 36.36% <0%> (-60.61%) ⬇️
Rocket.Chat/Managers/Socket/SocketManager.swift 42.1% <0%> (-6.15%) ⬇️
Rocket.Chat/Managers/AppManager.swift 41.61% <0%> (-4.7%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f796eb...cbedcb2. Read the comment docs.

@filipealva filipealva requested a review from rafaelks October 2, 2018 03:02
@filipealva filipealva changed the title [WIP][NEW] Text Attachment [NEW] Text Attachment Oct 2, 2018
@rafaelks rafaelks merged commit fd9a1a2 into feature/integrate-rc-view-controller Oct 3, 2018
@rafaelks rafaelks deleted the feature/text-attachment branch October 3, 2018 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants