This repository was archived by the owner on Jun 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 437
[NEW] Text Attachment #2227
Merged
rafaelks
merged 16 commits into
feature/integrate-rc-view-controller
from
feature/text-attachment
Oct 3, 2018
Merged
[NEW] Text Attachment #2227
rafaelks
merged 16 commits into
feature/integrate-rc-view-controller
from
feature/text-attachment
Oct 3, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/integrate-rc-view-controller #2227 +/- ##
========================================================================
- Coverage 27.92% 27.55% -0.37%
========================================================================
Files 407 409 +2
Lines 15243 15338 +95
========================================================================
- Hits 4257 4227 -30
- Misses 10986 11111 +125
Continue to review full report at Codecov.
|
rafaelks
approved these changes
Oct 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
It requires this PR merged
Also the animation doesn't feels good. I think removing the cell's background will help, but we maybe will have to implement a custom animation for this one, I'll leave it to do after, when applying themes and the missing appearance traits.