Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@cardoso
Copy link
Member

@cardoso cardoso commented Oct 2, 2018

@RocketChat/ios

@cardoso cardoso requested a review from rafaelks October 2, 2018 13:15
@cardoso cardoso changed the base branch from develop to feature/integrate-rc-view-controller October 2, 2018 13:15
@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #2233 into feature/integrate-rc-view-controller will decrease coverage by 0.24%.
The diff coverage is 0%.

Impacted file tree graph

@@                           Coverage Diff                            @@
##           feature/integrate-rc-view-controller    #2233      +/-   ##
========================================================================
- Coverage                                 27.55%   27.31%   -0.25%     
========================================================================
  Files                                       409      411       +2     
  Lines                                     15338    15477     +139     
========================================================================
  Hits                                       4227     4227              
- Misses                                    11111    11250     +139
Impacted Files Coverage Δ
...ontrollers/Chat/MessagesViewControllerBanner.swift 0% <0%> (ø)
.../Chat/MessagesViewControllerComposerDelegate.swift 0% <0%> (ø) ⬆️
...rollers/Chat/MessagesViewControllerUploading.swift 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9a1a2...86f0636. Read the comment docs.

Copy link
Contributor

@rafaelks rafaelks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! :-)

@rafaelks rafaelks merged commit 70a579d into feature/integrate-rc-view-controller Oct 3, 2018
@rafaelks rafaelks deleted the feat/new_composer_upload branch October 3, 2018 22:31
@rafaelks rafaelks added this to the 3.2.0 milestone Oct 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants