Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@Sameesunkaria
Copy link
Contributor

@RocketChat/ios

Now the theme is cached with the message to avoid repeated work. This allows us to not force update the message every time applyTheme is called.

@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

❗ No coverage uploaded for pull request base (feature/integrate-rc-view-controller@e55674f). Click here to learn what that means.
The diff coverage is 87.5%.

Impacted file tree graph

@@                           Coverage Diff                           @@
##             feature/integrate-rc-view-controller    #2258   +/-   ##
=======================================================================
  Coverage                                        ?   26.12%           
=======================================================================
  Files                                           ?      430           
  Lines                                           ?    16155           
  Branches                                        ?        0           
=======================================================================
  Hits                                            ?     4221           
  Misses                                          ?    11934           
  Partials                                        ?        0
Impacted Files Coverage Δ
...t/Views/Chat/New Chat/Cells/BasicMessageCell.swift 0% <0%> (ø)
Rocket.Chat/Managers/MessageTextCacheManager.swift 83.33% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e55674f...d7c9eb8. Read the comment docs.

@rafaelks rafaelks added this to the 3.2.0 milestone Oct 18, 2018
Copy link
Contributor

@rafaelks rafaelks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Sameesunkaria!!!

@rafaelks rafaelks merged commit 1a5732c into feature/integrate-rc-view-controller Oct 18, 2018
@rafaelks rafaelks deleted the improvement/chat-theming-performance branch October 18, 2018 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants