This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[IMPROVEMENT] Performance improvements, code simplification & prefetch one more page from database #2279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 7, 2018
| } | ||
| } | ||
|
|
||
| strongSelf.dataUpdateDelegate?.didUpdateChatData(newData: newSections, updatedItems: updatedItems) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 122 characters (line_length)
|
|
||
| if changes.sectionUpdated.contains(sectionIndex) { | ||
| for (itemIndex, item) in changes.elementUpdated.enumerated() { | ||
| if item.section == sectionIndex { |
There was a problem hiding this comment.
For Where Violation: where clauses are preferred over a single if inside a for. (for_where)
| UIView.performWithoutAnimation { | ||
| collectionView.reload(using: changeset, interrupt: { $0.changeCount > 100 }) { newData in | ||
| let changeset = StagedChangeset(source: strongSelf.internalData, target: target) | ||
| collectionView.reload(using: changeset, interrupt: { $0.changeCount > 100 }) { newData, changes in |
There was a problem hiding this comment.
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument. (multiple_closures_with_trailing_closure)
…a_from_remote [BUG] Missing data on the list & fixed unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
This pull-request was suppose to fix the empty cells, but I still didn't figure out what's happening (still investigating, but will send another PR once this is fixed). For now, this one includes: