This repository was archived by the owner on Jun 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 437
[FIX] Freezing video thumb generation & race condition on data #2309
Merged
rafaelks
merged 8 commits into
develop
from
chore/performance_and_race_condition_improvements
Nov 14, 2018
Merged
[FIX] Freezing video thumb generation & race condition on data #2309
rafaelks
merged 8 commits into
develop
from
chore/performance_and_race_condition_improvements
Nov 14, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipealva
approved these changes
Nov 13, 2018
Contributor
filipealva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
cardoso
approved these changes
Nov 13, 2018
Member
cardoso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✌️
…chore/performance_and_race_condition_improvements
…ithub.com:RocketChat/Rocket.Chat.iOS into chore/performance_and_race_condition_improvements
Codecov Report
@@ Coverage Diff @@
## develop #2309 +/- ##
===========================================
+ Coverage 26.11% 26.27% +0.16%
===========================================
Files 436 436
Lines 15918 15919 +1
===========================================
+ Hits 4157 4183 +26
+ Misses 11761 11736 -25
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios