Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@rafaelks
Copy link
Contributor

@rafaelks rafaelks commented Nov 13, 2018

@RocketChat/ios

  • Resolves race condition on accessing the data objects;
  • Resolves freezing on video thumb generation;
  • Make page size be always 30;

@rafaelks rafaelks added this to the 3.2.0 milestone Nov 13, 2018
Copy link
Contributor

@filipealva filipealva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✌️

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #2309 into develop will increase coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2309      +/-   ##
===========================================
+ Coverage    26.11%   26.27%   +0.16%     
===========================================
  Files          436      436              
  Lines        15918    15919       +1     
===========================================
+ Hits          4157     4183      +26     
+ Misses       11761    11736      -25
Impacted Files Coverage Δ
...t.Chat/Views/Cells/Chat/ChatMessageVideoView.swift 0% <0%> (ø) ⬆️
...t.Chat/Views/Subscriptions/FileTableViewCell.swift 0% <0%> (ø) ⬆️
...ews/Chat/New Chat/Cells/BaseVideoMessageCell.swift 0% <0%> (ø) ⬆️
...cket.Chat/Controllers/Chat/MessagesViewModel.swift 28.9% <0%> (-0.46%) ⬇️
...ontrollers/Base/Main/MainSplitViewController.swift 45% <0%> (-7.5%) ⬇️
...Chat/Controllers/Chat/MessagesViewController.swift 33.51% <0%> (-3.79%) ⬇️
Rocket.Chat/Managers/AppManager.swift 47.26% <0%> (+4.79%) ⬆️
Rocket.Chat/Managers/PushManager.swift 34.48% <0%> (+10.34%) ⬆️
...Chat/Models/Subscription/SubscriptionQueries.swift 100% <0%> (+30%) ⬆️
...anagers/Model/AuthManager/AuthManagerRecover.swift 96.96% <0%> (+60.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b57890...6d63bee. Read the comment docs.

@rafaelks rafaelks merged commit b6cb6db into develop Nov 14, 2018
@rafaelks rafaelks deleted the chore/performance_and_race_condition_improvements branch November 14, 2018 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants