This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[CHORE] Support empty title & alias on the message #2341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 22, 2018
Rocket.Chat/Views/Chat/New Chat/ChatItems/BaseTextAttachmentChatItem.swift
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #2341 +/- ##
===========================================
- Coverage 26.36% 26.25% -0.12%
===========================================
Files 440 440
Lines 16278 16349 +71
===========================================
Hits 4292 4292
- Misses 11986 12057 +71
Continue to review full report at Codecov.
|
cardoso
approved these changes
Nov 22, 2018
| avatar: message?.avatar, | ||
| emoji: message?.emoji, | ||
| alias: message?.alias, | ||
| date: message?.createdAt, |
| } | ||
|
|
||
| init(user: UnmanagedUser?, avatar: String?, emoji: String?, date: Date?, isUnread: Bool = false) { | ||
| init(user: UnmanagedUser?, avatar: String?, emoji: String?, alias: String?, date: Date?, isUnread: Bool = false) { |
Member
There was a problem hiding this comment.
What about doing the same thing here as you did in the other places?
Rocket.Chat/Views/Chat/New Chat/ChatItems/BaseTextAttachmentChatItem.swift
Outdated
Show resolved
Hide resolved
| init( | ||
| identifier: String, | ||
| title: String?, | ||
| descriptionText: String?, |
| super.init( | ||
| user: user, | ||
| avatar: message.avatar, | ||
| emoji: message.emoji, |
|
|
||
| super.init( | ||
| user: user, | ||
| avatar: message?.avatar, |
| init( | ||
| identifier: String, | ||
| fields: [UnmanagedField], | ||
| title: String, |
| super.init( | ||
| collapsed: collapsed, | ||
| user: user, | ||
| avatar: message?.avatar, |
| init(identifier: String, descriptionText: String?, videoURL: URL?, videoThumbPath: URL?, hasText: Bool, user: UnmanagedUser?, message: UnmanagedMessage?) { | ||
| init( | ||
| identifier: String, | ||
| descriptionText: String?, |
|
|
||
| super.init( | ||
| user: user, | ||
| avatar: message?.avatar, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Closes #2323