Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@rafaelks
Copy link
Contributor

@rafaelks rafaelks commented Nov 23, 2018

@RocketChat/ios

This pull-request fixes issues caused by my changes on themes for #2348 and also add supports to Dynamic Type in all of the authentication flow.

Screenshots

img_7720
img_7721
img_7722
img_7723
img_7724
img_7725
img_7726
img_7727
img_7728

@rafaelks rafaelks added this to the 3.2.0 milestone Nov 23, 2018
@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #2349 into improvement/optimize_size_calculation will decrease coverage by 0.21%.
The diff coverage is 50%.

Impacted file tree graph

@@                            Coverage Diff                            @@
##           improvement/optimize_size_calculation    #2349      +/-   ##
=========================================================================
- Coverage                                  26.23%   26.02%   -0.22%     
=========================================================================
  Files                                        440      440              
  Lines                                      16437    16421      -16     
=========================================================================
- Hits                                        4313     4273      -40     
- Misses                                     12124    12148      +24
Impacted Files Coverage Δ
Rocket.Chat/Theme/ThemeableViews.swift 44.17% <ø> (-13.11%) ⬇️
...Controllers/Auth/ConnectServerViewController.swift 58% <ø> (ø) ⬆️
...at/Controllers/Auth/LoginTableViewController.swift 0% <0%> (ø) ⬆️
...hat/Controllers/Auth/AuthTableViewController.swift 0% <0%> (ø) ⬆️
...t/Views/Cells/Auth/LoginServiceTableViewCell.swift 0% <0%> (ø) ⬆️
Rocket.Chat/Views/TextFields/StyledTextField.swift 97.56% <100%> (+0.5%) ⬆️
....Chat/Controllers/Auth/WelcomeViewController.swift 41.66% <100%> (-10.06%) ⬇️
Rocket.Chat/Views/Buttons/StyledButton.swift 66.03% <85.71%> (+0.65%) ⬆️
...xtensions/UITextField/UITextFieldClearButton.swift 0% <0%> (-100%) ⬇️
...ket.Chat/Views/Notification/NotificationView.swift 59.09% <0%> (-40.91%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a463b3...3f9331b. Read the comment docs.

@rafaelks rafaelks changed the title [WIP][IMPROVEMENT] Fixes & support to Dynamic Type on all auth flow [IMPROVEMENT] Fixes & support to Dynamic Type on all auth flow Nov 23, 2018
Copy link
Contributor

@filipealva filipealva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@rafaelks rafaelks merged commit a1f7d76 into improvement/optimize_size_calculation Nov 23, 2018
@rafaelks rafaelks deleted the improvement/auth_dynamic_type branch November 23, 2018 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants