This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[CRASH] AuthTableViewController.swift line 128 AuthTableViewController.viewDidLoad() #2394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to present auth or login screens, use the property that is set right after validating the URL that was actually used to connect successfully
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
This crash is caused due to a nil serverURL when loading an AuthTableViewController. I couldn't reproduce it, so I took some actions that will prevent this crash from happening on any given scenario:
AuthTableViewControllerandLoginTableViewControllerserverURL propertiesConnectViewControllerat the time of injecting it into Auth or Login screens. Instead of doing that I just used the stored version of the URL that we set right after connecting and validating it, i.e. it will never be nil if the connection is working properly.Closes #2385