Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@rafaelks
Copy link
Contributor

@rafaelks rafaelks commented Jan 2, 2019

@RocketChat/ios

Fixes a crash happening on iOS 11 devices, wasn't able to reproduce the issue but figured a way to prevent this from happening again (and updated tests for it).

@rafaelks rafaelks added this to the 3.3.0 milestone Jan 2, 2019
@rafaelks rafaelks requested review from cardoso and filipealva January 2, 2019 14:15
@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #2470 into develop will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2470      +/-   ##
===========================================
+ Coverage    26.24%   26.32%   +0.08%     
===========================================
  Files          456      456              
  Lines        16936    16909      -27     
===========================================
+ Hits          4445     4452       +7     
+ Misses       12491    12457      -34
Impacted Files Coverage Δ
...at/Controllers/Auth/LoginTableViewController.swift 0% <ø> (ø) ⬆️
.../Views/Cells/Auth/AuthSeparatorTableViewCell.swift 0% <ø> (ø) ⬆️
...t/Views/Cells/Auth/LoginServiceTableViewCell.swift 0% <ø> (ø) ⬆️
...hat/Views/Cells/Chat/ChatMessageDaySeparator.swift 0% <ø> (ø) ⬆️
...ws/Cells/Auth/ShowMoreSeparatorTableViewCell.swift 0% <ø> (ø) ⬆️
....Chat/Controllers/Chat/MessagesSizingManager.swift 70% <100%> (+16.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d52ad7...91c8f75. Read the comment docs.

Copy link
Member

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rafaelks rafaelks merged commit ba97b30 into develop Jan 2, 2019
@rafaelks rafaelks deleted the fix/crash_invalid_sizes_message_cell branch January 2, 2019 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants