[NEW] Directory #2588
[NEW] Directory #2588
Conversation
…feature/directory.2290
…feature/directory.2290
| } | ||
|
|
||
| @objc func recognizeDirectoryTapGesture(_ recognizer: UITapGestureRecognizer) { | ||
| guard let controller = UIStoryboard(name: "Directory", bundle: Bundle.main).instantiateInitialViewController() else { return } |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 134 characters (line_length)
| #endif | ||
|
|
||
| private func _display(_ image: Image, _ transition: ImageLoadingOptions.Transition?, _ fromMemCache: Bool, _ newContentMode: _ContentMode?) { | ||
| private func _display(_ image: Image, _ transition: ImageLoadingOptions.Transition?, _ alwaysTransition: Bool, _ fromMemCache: Bool, _ newContentMode: _ContentMode?) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 171 characters (line_length)
| _display(image, options.transition, options.alwaysTransition, fromMemCache, options.contentModes?.success) | ||
| } else if let failureImage = options.failureImage { | ||
| _display(failureImage, options.failureImageTransition, fromMemCache, options.contentModes?.failure) | ||
| _display(failureImage, options.failureImageTransition, options.alwaysTransition, fromMemCache, options.contentModes?.failure) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 137 characters (line_length)
| /// The image transition animation performed when displaying a failure image. | ||
| /// `.nil` by default. | ||
| public var failureImageTransition: Transition? | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
|
|
||
| extension DirectoryViewController { | ||
|
|
||
| override func tableView(_ tableView: UITableView, willDisplay cell: UITableViewCell, forRowAt indexPath: IndexPath) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 121 characters (line_length)
| } | ||
|
|
||
| func cellFor(channel: UnmanagedSubscription, at indexPath: IndexPath) -> DirectoryChannelCell { | ||
| guard let cell = tableView.dequeueReusableCell(withIdentifier: DirectoryChannelCell.identifier, for: indexPath) as? DirectoryChannelCell else { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 151 characters (line_length)
| } | ||
|
|
||
| func cellFor(user: UnmanagedUser, at indexPath: IndexPath) -> DirectoryUserCell { | ||
| guard let cell = tableView.dequeueReusableCell(withIdentifier: DirectoryUserCell.identifier, for: indexPath) as? DirectoryUserCell else { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 145 characters (line_length)
| let sort = type == .channels ? "sort={\"usersCount\":-1}&" : "sort={\"username\":1}&" | ||
|
|
||
| if let encodedQuery = query.addingPercentEncoding(withAllowedCharacters: .urlQueryAllowed) { | ||
| self.query = "\(sort)query={\"text\": \"\(encodedQuery)\", \"type\": \"\(type)\", \"workspace\": \"\(workspace)\"}" |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 127 characters (line_length)
Codecov Report
@@ Coverage Diff @@
## develop #2588 +/- ##
===========================================
- Coverage 26.6% 26.25% -0.36%
===========================================
Files 456 463 +7
Lines 16903 17139 +236
===========================================
+ Hits 4497 4499 +2
- Misses 12406 12640 +234
Continue to review full report at Codecov.
|
This pull-request adds the support to Directory on the iOS app and also some minor bug fixes:
Closes #2290