Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@rudrankriyam
Copy link
Contributor

@RocketChat/ios

Tiny fix - Safe Layout Guide in ChatPreviewModeView.

Simulator Screen Shot - iPhone XR - 2019-04-02 at 11 22 06

Screenshot 2019-04-02 at 11 21 48 AM

Closes #2628

Safe Layout Guide for ChatPreviewModeView
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #2629 into develop will decrease coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2629      +/-   ##
===========================================
- Coverage    26.17%   25.99%   -0.18%     
===========================================
  Files          463      463              
  Lines        17224    17216       -8     
===========================================
- Hits          4509     4476      -33     
- Misses       12715    12740      +25
Impacted Files Coverage Δ
...ntrollers/Chat/MessagesViewControllerJoining.swift 70.45% <100%> (ø) ⬆️
...anagers/Model/AuthManager/AuthManagerRecover.swift 36.36% <0%> (-60.61%) ⬇️
Rocket.Chat/Extensions/Models/AuthExtensions.swift 66.66% <0%> (-33.34%) ⬇️
...Chat/Models/Subscription/SubscriptionQueries.swift 70% <0%> (-30%) ⬇️
Rocket.Chat/Managers/PushManager.swift 24.13% <0%> (-10.35%) ⬇️
Rocket.Chat/Managers/AppManager.swift 36.04% <0%> (-4.07%) ⬇️
...Chat/Models/Mapping/SubscriptionModelMapping.swift 87.71% <0%> (-1.17%) ⬇️
...iews/Cells/Subscription/BaseSubscriptionCell.swift 0% <0%> (ø) ⬆️
...at/Views/Cells/Subscription/SubscriptionCell.swift 0% <0%> (ø) ⬆️
Rocket.Chat/Models/Subscription/Subscription.swift 48.88% <0%> (+2.08%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac1a172...3736c25. Read the comment docs.

@SV8
Copy link

SV8 commented Apr 2, 2019

Very nice.

@rafaelks
Copy link
Contributor

rafaelks commented Apr 2, 2019

@snuff4 Thank you very much!!! :-)

@rafaelks rafaelks added this to the 3.5.0 milestone Apr 2, 2019
@rafaelks rafaelks self-requested a review April 2, 2019 11:12
@rafaelks rafaelks merged commit 3949c4c into RocketChat:develop Apr 2, 2019
@rudrankriyam rudrankriyam deleted the preview_view branch April 10, 2019 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] "Join Channel" button overlapping home bar on iPhone X/XS/Max

3 participants