Skip to content

Incoming WebHook Integration: Save button only checks 'dirty' state, allowing invalid submissions #39100

@dodaa08

Description

@dodaa08

Description:

The "Save" button in the Incoming Webhook administration page is enabled as soon as any field in the form is modified, even if mandatory fields like "Post to Channel" and "Post as" are left empty.

Screencast.From.2026-02-26.21-54-18.mp4

Steps to reproduce:

  1. Navigate to Administration -> Integrations.
  2. Click on "New" then select "Incoming Webhook".
  3. Leave the required fields "Post to Channel" and "Post as" empty.
  4. Type any text into the optional "Name" field to trigger the form's "dirty" state.
  5. Observe that the "Save" button in the footer becomes enabled.
  6. Click "Save".

Expected behavior:

The "Save" button should remain disabled until all required fields satisfy the validation rules (i.e., they are not empty).

Actual behavior:

The "Save" button is enabled based solely on the form being modified, allowing the submission of incomplete data.

Server Setup Information:

  • Version of Rocket.Chat Server: 8.3.0-develop
  • Operating System: Fedora Workstation 41
  • Deployment Method: Local development
  • NodeJS Version: 22.16.0

Client Setup Information

  • Browser Version: Brave
  • Operating System: Fedora Workstation 41

Additional context

The Save button in the footer is currently programmed to become active as soon as any change is made to the form (the isDirty state).

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions