Skip to content

Comments

chore: streams refactor#29585

Merged
ggazzo merged 5 commits intodevelopfrom
chore/streams
Jul 25, 2023
Merged

chore: streams refactor#29585
ggazzo merged 5 commits intodevelopfrom
chore/streams

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 20, 2023

the idea is to reduce the number of subscriptions related to apps, there's no need to be one for each action, they always happen together and don't happen that often

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

⚠️ No Changeset found

Latest commit: a6c58de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo changed the title reduce apps to on single stream chore: streams refactor Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #29585 (a6c58de) into develop (e1eac77) will decrease coverage by 0.19%.
The diff coverage is 21.05%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29585      +/-   ##
===========================================
- Coverage    48.50%   48.32%   -0.19%     
===========================================
  Files          700      699       -1     
  Lines        13864    13873       +9     
  Branches      2441     2435       -6     
===========================================
- Hits          6725     6704      -21     
- Misses        6760     6804      +44     
+ Partials       379      365      -14     
Flag Coverage Δ
e2e 46.39% <21.05%> (-0.20%) ⬇️
unit 64.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added this to the 6.4.0 milestone Jul 25, 2023
@ggazzo ggazzo marked this pull request as ready for review July 25, 2023 14:29
@ggazzo ggazzo requested a review from a team as a code owner July 25, 2023 14:29
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 25, 2023
@ggazzo ggazzo merged commit 6fd370f into develop Jul 25, 2023
@ggazzo ggazzo deleted the chore/streams branch July 25, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants