Skip to content

Comments

fix: Change search box placeholder text for windows devices#31074

Merged
kodiakhq[bot] merged 2 commits intoRocketChat:developfrom
mayank6725:fix/change-search-box-placeholder-text-for-windows
Nov 27, 2023
Merged

fix: Change search box placeholder text for windows devices#31074
kodiakhq[bot] merged 2 commits intoRocketChat:developfrom
mayank6725:fix/change-search-box-placeholder-text-for-windows

Conversation

@mayank6725
Copy link
Contributor

@mayank6725 mayank6725 commented Nov 25, 2023

This PR aims to resolve issue #31076

Description

The search box placeholder text says ' Search (^+K) ' for windows devices. The caret (^) key is used on Mac devices to define Ctrl key and not on windows laptops. Windows laptop only has a Ctrl key with no caret(^)

Supporting proof

https://i0.wp.com/bigtechquestion.com/wp-content/uploads/2021/07/control.jpg?resize=600%2C600&ssl=1

Before

before

After

After

Steps to reproduce:

  1. Go to open.rocket.chat on a web browser running on windows
  2. Click on the search icon next to home icon
  3. You can see the placeholder text as (^+K)

What was done to resolve this?

I just changed the placeholder text for windows devices in SearchList.tsx file from '\u 2303 + K' to 'Ctrl+K'

@mayank6725 mayank6725 requested a review from a team as a code owner November 25, 2023 07:07
@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2023

⚠️ No Changeset found

Latest commit: 84777a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mayank6725 mayank6725 closed this Nov 25, 2023
@CLAassistant
Copy link

CLAassistant commented Nov 25, 2023

CLA assistant check
All committers have signed the CLA.

@mayank6725 mayank6725 reopened this Nov 25, 2023
@mangaljee
Copy link

i am doing this work

@mayank6725
Copy link
Contributor Author

Hi @mangaljee,
Its already done. Please check the attached PR.
Thanks

@MartinSchoeler
Copy link
Member

Good catch! Thanks for the contribution!

@codecov
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #31074 (84777a6) into develop (38c5302) will increase coverage by 4.82%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31074      +/-   ##
===========================================
+ Coverage    46.31%   51.13%   +4.82%     
===========================================
  Files          766      807      +41     
  Lines        14675    15141     +466     
  Branches      2753     2820      +67     
===========================================
+ Hits          6797     7743     +946     
+ Misses        7479     6963     -516     
- Partials       399      435      +36     
Flag Coverage Δ
e2e 48.04% <ø> (+5.64%) ⬆️
unit 66.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit e2ea90a into RocketChat:develop Nov 27, 2023
@mayank6725 mayank6725 deleted the fix/change-search-box-placeholder-text-for-windows branch November 28, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants