Skip to content

feat: added onConfirm loading state to generic modal#33889

Draft
aleksandernsilva wants to merge 2 commits into
developfrom
feat/generic-modal-loading-state
Draft

feat: added onConfirm loading state to generic modal#33889
aleksandernsilva wants to merge 2 commits into
developfrom
feat/generic-modal-loading-state

Conversation

@aleksandernsilva
Copy link
Copy Markdown
Contributor

@aleksandernsilva aleksandernsilva commented Nov 5, 2024

Proposed changes (including videos or screenshots)

This PR is exploring the idea of adding a loading state to the GenericModal button based on the promise returned by the onConfirm callback.

❗ At the moment there's no plan of merging this PR. ❗

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Nov 5, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 6287fec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 5, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33889/
on branch gh-pages at 2024-11-22 18:42 UTC

@aleksandernsilva aleksandernsilva force-pushed the feat/generic-modal-loading-state branch from fd6b7fd to e04ac1c Compare November 5, 2024 19:37
@aleksandernsilva aleksandernsilva force-pushed the feat/generic-modal-loading-state branch from 6287fec to 61ccd12 Compare November 22, 2024 18:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 22, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.79%. Comparing base (6dca2b0) to head (61ccd12).
⚠️ Report is 2730 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33889      +/-   ##
===========================================
+ Coverage    75.40%   75.79%   +0.39%     
===========================================
  Files          493      510      +17     
  Lines        21487    22063     +576     
  Branches      5336     5385      +49     
===========================================
+ Hits         16202    16723     +521     
- Misses        4645     4694      +49     
- Partials       640      646       +6     
Flag Coverage Δ
unit 75.79% <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant