Skip to content

test: Updated Omnichannel tests from using faker to createFakeVisitor#33917

Draft
aleksandernsilva wants to merge 4 commits into
developfrom
test/omni-fake-visitors
Draft

test: Updated Omnichannel tests from using faker to createFakeVisitor#33917
aleksandernsilva wants to merge 4 commits into
developfrom
test/omni-fake-visitors

Conversation

@aleksandernsilva
Copy link
Copy Markdown
Contributor

@aleksandernsilva aleksandernsilva commented Nov 7, 2024

Proposed changes (including videos or screenshots)

In an effort to avoid duplicated visitor names this PR updates the remaining tests using faker.person.firstName to use createFakeVisitor which provides unique names.

Screenshot 2024-11-07 at 18 41 33

Issue(s)

FLAKY-922

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Nov 7, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 7, 2024

⚠️ No Changeset found

Latest commit: 34078ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aleksandernsilva aleksandernsilva changed the title test: Updated Omnichannel tests using faker.person.firstName to createFakeVisitor test: Updated Omnichannel tests from using faker to createFakeVisitor Nov 7, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 7, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33917/
on branch gh-pages at 2024-11-08 18:34 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 7, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.20%. Comparing base (322bafd) to head (34078ac).
⚠️ Report is 2674 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33917   +/-   ##
========================================
  Coverage    75.20%   75.20%           
========================================
  Files          495      495           
  Lines        21595    21595           
  Branches      5362     5362           
========================================
  Hits         16240    16240           
  Misses        4713     4713           
  Partials       642      642           
Flag Coverage Δ
unit 75.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant