Skip to content

feat: auditing settings#33935

Merged
ggazzo merged 10 commits into
developfrom
feat/audit-settings
Nov 20, 2024
Merged

feat: auditing settings#33935
ggazzo merged 10 commits into
developfrom
feat/audit-settings

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented Nov 11, 2024

Proposed changes (including videos or screenshots)

Issue(s)

LOG-2

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Nov 11, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 11, 2024

⚠️ No Changeset found

Latest commit: 9e98402

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo force-pushed the feat/audit-settings branch from 5e8720f to 9b1588a Compare November 11, 2024 13:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 11, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33935/
on branch gh-pages at 2024-11-20 01:15 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 44.73684% with 21 lines in your changes missing coverage. Please review.

Project coverage is 75.79%. Comparing base (de6bd32) to head (9e98402).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33935      +/-   ##
===========================================
- Coverage    75.85%   75.79%   -0.06%     
===========================================
  Files          509      510       +1     
  Lines        22026    22063      +37     
  Branches      5381     5385       +4     
===========================================
+ Hits         16707    16723      +16     
- Misses        4674     4694      +20     
- Partials       645      646       +1     
Flag Coverage Δ
unit 75.79% <44.73%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@ggazzo ggazzo force-pushed the feat/audit-settings branch 2 times, most recently from eb252eb to 29b0007 Compare November 19, 2024 13:22
@ggazzo ggazzo force-pushed the feat/audit-settings branch 2 times, most recently from 264b222 to b698aa1 Compare November 19, 2024 16:12
Comment thread apps/meteor/app/api/server/v1/assets.ts
Comment thread apps/meteor/app/api/server/v1/assets.ts
Comment thread apps/meteor/app/api/server/v1/misc.ts
Comment thread apps/meteor/app/api/server/v1/misc.ts
Comment thread apps/meteor/app/apps/server/bridges/settings.ts
Comment thread apps/meteor/app/lib/server/methods/saveSettings.ts Outdated
Comment thread apps/meteor/app/version-check/server/functions/buildVersionUpdateMessage.ts Outdated
Comment thread apps/meteor/server/settings/lib/auditedSettingUpdates.ts
@ggazzo ggazzo force-pushed the feat/audit-settings branch from b698aa1 to 0a66873 Compare November 19, 2024 18:21
@ggazzo ggazzo force-pushed the feat/audit-settings branch from 0a66873 to 2adfad7 Compare November 19, 2024 18:56
@ggazzo ggazzo marked this pull request as ready for review November 19, 2024 19:50
@ggazzo ggazzo requested review from a team as code owners November 19, 2024 19:50
@ggazzo ggazzo added this to the 7.1.0 milestone Nov 19, 2024
sampaiodiego
sampaiodiego previously approved these changes Nov 19, 2024
@ggazzo ggazzo merged commit 79bbbd6 into develop Nov 20, 2024
@ggazzo ggazzo deleted the feat/audit-settings branch November 20, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants