Skip to content

fix: #34034 Fixed Push Notification Gateway#34036

Open
arth-1 wants to merge 4 commits into
RocketChat:developfrom
arth-1:develop
Open

fix: #34034 Fixed Push Notification Gateway#34036
arth-1 wants to merge 4 commits into
RocketChat:developfrom
arth-1:develop

Conversation

@arth-1
Copy link
Copy Markdown

@arth-1 arth-1 commented Nov 22, 2024

Fixed sendNotification function to ensure proper asynchronous execution by removing unnecessary return. Improved error handling and logging to ensure reliable push notifications without affecting the flow of the application

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Fixed sendNotification function to ensure proper asynchronous execution by removing unnecessary return. Improved error handling and logging to ensure reliable push notifications without affecting the flow of the application
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Nov 22, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: 7650689

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 22, 2024

CLA assistant check
All committers have signed the CLA.

@arth-1 arth-1 changed the title FIX #34034 Multiple Push notificatons gateways FIX #34034 Fixed Push Notification Gateway Nov 22, 2024
@arth-1 arth-1 marked this pull request as draft November 22, 2024 16:32
@arth-1 arth-1 closed this Nov 22, 2024
@arth-1 arth-1 reopened this Nov 22, 2024
@arth-1 arth-1 marked this pull request as ready for review November 22, 2024 16:39
@arth-1 arth-1 changed the title FIX #34034 Fixed Push Notification Gateway fix: #34034 Fixed Push Notification Gateway Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants