Skip to content

fix: Keyboard Shortcut to Make Text Bold Opens Bookmarks on Firefox.#34096

Open
Srayash wants to merge 1 commit into
RocketChat:developfrom
Srayash:fix/bold-shortcut-open-bookmarks-on-firefox
Open

fix: Keyboard Shortcut to Make Text Bold Opens Bookmarks on Firefox.#34096
Srayash wants to merge 1 commit into
RocketChat:developfrom
Srayash:fix/bold-shortcut-open-bookmarks-on-firefox

Conversation

@Srayash
Copy link
Copy Markdown

@Srayash Srayash commented Dec 1, 2024

Proposed changes (including videos or screenshots)

When the Ctrl + b or Cmd + b shortcut is pressed, the event’s default behavior (opening the bookmarks sidebar) is prevented using event.preventDefault().

Issue(s)

fixes #34021

Steps to test or reproduce

  1. Open RocketChat in Firefox.
  2. Press cmd(or Ctrl) + b.

Further comments

@Srayash Srayash requested a review from a team as a code owner December 1, 2024 15:09
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Dec 1, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 1, 2024

⚠️ No Changeset found

Latest commit: 7011409

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard Shortcut to Make Text Bold Opens Bookmarks on Firefox

1 participant