fix: Cursor can't move up/down after a smile.#34183
Conversation
|
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
I think this bug is because of a bug of the trigger mode of the emoji popup. The triggerLength of emoji is set to 2. I guess it means the emoji popup should show up when the cursor in the 2nd place after ":". The emoji popup did show up when the cursor in the 2nd place after ":". The "shouldPopupPreview" works well, but "popup" didn't. The "popup" has a value when the cursor in the 1st place (and other situation), then it takes up the up and down keys. That's why the "cursor can't move up/down after a smile". Change the "popup"'s trigger mode the same as "shouldPopupPreview"'s can fix this bug.( I don't know if such modification will cause some other errors, such as errors related to @ or # ?. What's the use of "shouldPopupPreview"? Maybe we can change the "popup"'s trigger mode the same as "shouldPopupPreview"'s , and then just delete "shouldPopupPreview".) I'm not good at English, welcome to point out my mistakes. |
|
Hello Tushar, I tried your commits, it didn't work. Did you submit the right changes? or something wrong with me? |
|
Hello @IITI-tushar! I see you did some work on this bug. I noticed this PR has been open for a while and now has some merge conflicts. I've set up the project and am willing to help resolve the conflicts and get this ready to merge. Would you be open to me assisting with this? Thanks! |
|
Hi @mayyank1 . This issue has been around for a long time and should have been resolved by now. |
|
Thanks for the encouragement, @fzh075! I agree, it would be great to get this fixed. I will wait until Tuesday (October 14) to give the original author a final chance to respond. If I don't hear back by then, I will proceed with creating a new PR that resolves the issue. |
|
Hi @mayyank1 , sorry. What I mean is that this issue have been solved. |
Recording.2025-10-12.001942.mp4@fzh075 I am Still facing this issue cursor is not moving when it is in front of smile. Can you please confirm it |
|
@fzh075 And why this issue is open can you please guide me through this. |
|
@mayyank1 Sorry, it was not resolved. Thank you for your work. |
|
OK @fzh075 |




Proposed changes (including videos or screenshots)
Cursor can't be moved up and down right after a smile (:) for example).
While you can do it from inside a smile (between : and )).
With this pr ,this issue has now been fixed. As shown in the attached video, the cursor can seamlessly move up and down after a smile.
Issue(s)
#33353
Steps to test or reproduce
Further comments
2024-12-16.14-57-11.mp4