Skip to content

fix: Cursor can't move up/down after a smile.#34183

Open
IITI-tushar wants to merge 1 commit into
RocketChat:developfrom
IITI-tushar:fix/cursor-cant-move-up/down-after-a-smile
Open

fix: Cursor can't move up/down after a smile.#34183
IITI-tushar wants to merge 1 commit into
RocketChat:developfrom
IITI-tushar:fix/cursor-cant-move-up/down-after-a-smile

Conversation

@IITI-tushar
Copy link
Copy Markdown

@IITI-tushar IITI-tushar commented Dec 16, 2024

Proposed changes (including videos or screenshots)

Cursor can't be moved up and down right after a smile (:) for example).
While you can do it from inside a smile (between : and )).
With this pr ,this issue has now been fixed. As shown in the attached video, the cursor can seamlessly move up and down after a smile.

Issue(s)



#33353

Steps to test or reproduce

Further comments

2024-12-16.14-57-11.mp4

@IITI-tushar IITI-tushar requested a review from a team as a code owner December 16, 2024 10:11
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: 256ecc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Dec 16, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@IITI-tushar IITI-tushar changed the title Fix Cursor can't move up/down after a smile /update messageBox.tsx Fix: Cursor can't move up/down after a smile. Dec 16, 2024
@IITI-tushar IITI-tushar changed the title Fix: Cursor can't move up/down after a smile. fix: Cursor can't move up/down after a smile. Dec 16, 2024
@fzh075
Copy link
Copy Markdown

fzh075 commented Dec 17, 2024

I think this bug is because of a bug of the trigger mode of the emoji popup.

image

The triggerLength of emoji is set to 2. I guess it means the emoji popup should show up when the cursor in the 2nd place after ":".

image

The emoji popup did show up when the cursor in the 2nd place after ":". The "shouldPopupPreview" works well, but "popup" didn't. The "popup" has a value when the cursor in the 1st place (and other situation), then it takes up the up and down keys. That's why the "cursor can't move up/down after a smile". Change the "popup"'s trigger mode the same as "shouldPopupPreview"'s can fix this bug.( I don't know if such modification will cause some other errors, such as errors related to @ or # ?. What's the use of "shouldPopupPreview"? Maybe we can change the "popup"'s trigger mode the same as "shouldPopupPreview"'s , and then just delete "shouldPopupPreview".)

image
image

I'm not good at English, welcome to point out my mistakes.

@fzh075
Copy link
Copy Markdown

fzh075 commented Dec 17, 2024

Hello Tushar, I tried your commits, it didn't work. Did you submit the right changes? or something wrong with me?

@mayyank1
Copy link
Copy Markdown

Hello @IITI-tushar! I see you did some work on this bug. I noticed this PR has been open for a while and now has some merge conflicts.

I've set up the project and am willing to help resolve the conflicts and get this ready to merge. Would you be open to me assisting with this? Thanks!

@fzh075
Copy link
Copy Markdown

fzh075 commented Oct 11, 2025

Hi @mayyank1 . This issue has been around for a long time and should have been resolved by now.

@mayyank1
Copy link
Copy Markdown

Thanks for the encouragement, @fzh075! I agree, it would be great to get this fixed.

I will wait until Tuesday (October 14) to give the original author a final chance to respond. If I don't hear back by then, I will proceed with creating a new PR that resolves the issue.

@fzh075
Copy link
Copy Markdown

fzh075 commented Oct 11, 2025

Hi @mayyank1 , sorry. What I mean is that this issue have been solved.

@mayyank1
Copy link
Copy Markdown

Recording.2025-10-12.001942.mp4

@fzh075 I am Still facing this issue cursor is not moving when it is in front of smile. Can you please confirm it

@mayyank1
Copy link
Copy Markdown

@fzh075 And why this issue is open can you please guide me through this.

@fzh075
Copy link
Copy Markdown

fzh075 commented Oct 11, 2025

@mayyank1 Sorry, it was not resolved. Thank you for your work.

@mayyank1
Copy link
Copy Markdown

OK @fzh075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants