Skip to content

feat: Open action menu on right click on message in electron client but not in web browser#34835

Open
DevRish wants to merge 2 commits into
RocketChat:developfrom
DevRish:open-action-menu-on-right-click
Open

feat: Open action menu on right click on message in electron client but not in web browser#34835
DevRish wants to merge 2 commits into
RocketChat:developfrom
DevRish:open-action-menu-on-right-click

Conversation

@DevRish
Copy link
Copy Markdown

@DevRish DevRish commented Dec 26, 2024

Proposed changes (including videos or screenshots)

This PR adds the feature of opening the toolbar action menu (the menu that appears on clicking the 3 dots icon in message toolbar) of a message on right clicking on it; only in the desktop application (electron client), but not in the web application (default right click behaviour is retained on browser).

2024-12-27.00-56-15.mp4

Issue(s)

#32387

Steps to test or reproduce

In the RocketChat desktop application, on right clicking on a message, the action menu doesn't open currently. The feature was requested in #32387 along with description of expected steps.

Further comments

  • The feature this PR adds is actually on the desktop application. However, since the electron app renders the web app itself in a webview, the changes necessary for the feature had to be made to the web app itself.
  • This implementation uses props instead of directly referencing HTML DOM elements (as advised on a previously closed PR attached to this issue)
  • This implementation adds the feature to the desktop app only, the web app functions just as it did before

@DevRish DevRish requested a review from a team as a code owner December 26, 2024 19:35
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Dec 26, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 26, 2024

⚠️ No Changeset found

Latest commit: 2ba66e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant