You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Proposed changes (including videos or screenshots)
Introduce a new MarketplaceErrorHandler class that is going to be responsible for parsing marketplace-api errors and return the according error message strings from it.
Issue(s)
Steps to test or reproduce
Since we depend on having marketplace throwing errors to test this feature, I created a simple application that works as a proxy for marketplace, you can check it over here: https://github.com/Gustrb/api-stubber
It is pretty simple, and to run Rocket.Chat pointing at it instead of the actual marketplace one can simply:
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.17%. Comparing base (a5b4584) to head (46234ac). ⚠️ Report is 2301 commits behind head on develop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Introduce a new MarketplaceErrorHandler class that is going to be responsible for parsing marketplace-api errors and return the according error message strings from it.
Issue(s)
Steps to test or reproduce
Since we depend on having marketplace throwing errors to test this feature, I created a simple application that works as a proxy for marketplace, you can check it over here: https://github.com/Gustrb/api-stubber
It is pretty simple, and to run Rocket.Chat pointing at it instead of the actual marketplace one can simply:
Note: This assumes you are running the proxy at port 3001, while the default is 3000, this is done since the Rocket.Chat default port is also 3000.
Then, to test specific errors, you can tweak the
config.jsonfileFurther comments
CONN-64