You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue: The issue (#33793) describes a problem where usernames in notifications are not highlighted correctly when the user's language is set to Russian.
Proposed Changes: The PR likely modifies the translation string for the notification message to ensure proper username highlighting.
Key Changes
The main change in this PR is updating the translation string for the Russian language. Specifically:
The old string: "Username_is_already_in_here": ""@%s" уже здесь."
The new string: "Username_is_already_in_here": "@%s уже здесь."
This change replaces double quotes (") with backticks (`) around the username placeholder (@%s) to ensure proper rendering and highlighting in notifications.
Why This Fix Works
The backticks (`) ensure that the username is rendered as a code block or highlighted text in notifications.
This prevents issues with escaping double quotes (") in the notification message, which can cause rendering problems.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
KUSHAL-BANKHEDE
changed the title
Fix username highlight issue in notifications when user language is set to Russian (#33793)
Fix username highlight issue in notifications when user language is set to Russian
Feb 6, 2025
KUSHAL-BANKHEDE
changed the title
Fix username highlight issue in notifications when user language is set to Russian
fix: Fix username highlight issue in notifications when user language is set to Russian
Feb 6, 2025
KUSHAL-BANKHEDE
changed the title
fix: Fix username highlight issue in notifications when user language is set to Russian
fix: Username highlight issue in notifications when user language is set to Russian
Feb 6, 2025
hey, I think we could also tacle a different issue in the translation, in russian we don't use quotes, they use: «Name» уже здесь
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: The issue (#33793) describes a problem where usernames in notifications are not highlighted correctly when the user's language is set to Russian.
Proposed Changes: The PR likely modifies the translation string for the notification message to ensure proper username highlighting.
Key Changes
The main change in this PR is updating the translation string for the Russian language. Specifically:
The old string: "Username_is_already_in_here": ""@%s" уже здесь."
The new string: "Username_is_already_in_here": "@%s
уже здесь."This change replaces double quotes (") with backticks (`) around the username placeholder (@%s) to ensure proper rendering and highlighting in notifications.
Why This Fix Works
The backticks (`) ensure that the username is rendered as a code block or highlighted text in notifications.
This prevents issues with escaping double quotes (") in the notification message, which can cause rendering problems.