Skip to content

fix: Username highlight issue in notifications when user language is set to Russian#35144

Open
KUSHAL-BANKHEDE wants to merge 2 commits into
RocketChat:developfrom
KUSHAL-BANKHEDE:fix/username-highlight-russian
Open

fix: Username highlight issue in notifications when user language is set to Russian#35144
KUSHAL-BANKHEDE wants to merge 2 commits into
RocketChat:developfrom
KUSHAL-BANKHEDE:fix/username-highlight-russian

Conversation

@KUSHAL-BANKHEDE
Copy link
Copy Markdown

Issue: The issue (#33793) describes a problem where usernames in notifications are not highlighted correctly when the user's language is set to Russian.

Proposed Changes: The PR likely modifies the translation string for the notification message to ensure proper username highlighting.

Key Changes
The main change in this PR is updating the translation string for the Russian language. Specifically:

The old string: "Username_is_already_in_here": ""@%s" уже здесь."

The new string: "Username_is_already_in_here": "@%s уже здесь."

This change replaces double quotes (") with backticks (`) around the username placeholder (@%s) to ensure proper rendering and highlighting in notifications.

Why This Fix Works
The backticks (`) ensure that the username is rendered as a code block or highlighted text in notifications.

This prevents issues with escaping double quotes (") in the notification message, which can cause rendering problems.

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Feb 6, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: b042e99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KUSHAL-BANKHEDE KUSHAL-BANKHEDE changed the title Fix username highlight issue in notifications when user language is set to Russian (#33793) Fix username highlight issue in notifications when user language is set to Russian Feb 6, 2025
@KUSHAL-BANKHEDE KUSHAL-BANKHEDE changed the title Fix username highlight issue in notifications when user language is set to Russian fix: Fix username highlight issue in notifications when user language is set to Russian Feb 6, 2025
@KUSHAL-BANKHEDE KUSHAL-BANKHEDE changed the title fix: Fix username highlight issue in notifications when user language is set to Russian fix: Username highlight issue in notifications when user language is set to Russian Feb 6, 2025
@Gustrb
Copy link
Copy Markdown
Contributor

Gustrb commented Feb 6, 2025

hey, I think we could also tacle a different issue in the translation, in russian we don't use quotes, they use: «Name» уже здесь

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants