feat: Auto-format Authentication Code with Hyphen#35179
Open
dhairyashiil wants to merge 3 commits into
Open
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 1084d65 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Auto-format Authentication Code with Hyphen
Proposed changes (including videos or screenshots)
In the current authentication code input process, users can enter the code in two formats:
123456or123-456. This can lead to confusion as users may not always know if they should manually add the hyphen (-).Solution:
This feature automatically adds a hyphen (
-) after every three digits once the user enters the first three characters. The code will appear as123-456, and users will be able to continue entering the remaining digits without needing to manually insert the hyphen. This improves the user experience and ensures the correct format is always followed.Screenshots/Video:
hyphen.in.authentication.code.mp4
Issue(s)
Closes #35178
Steps to test or reproduce
Step 0: Enable Two-factor authentication First (Profile -> Security -> Two-factor authentication via email)
-) should automatically appear after the third digit (e.g.,123-).123-456).123456and123-456formats are accepted.Further comments
This solution should simplify the process for users and eliminate any confusion regarding whether they need to manually enter the hyphen. It is a small UI improvement that enhances usability without impacting the backend or requiring complex changes.
Let me know if you need any changes or improvements, and I look forward to your feedback.