Skip to content

fix: Duplicate Toast Notification on Invite-Link#35345

Open
amitkumarashutosh wants to merge 6 commits into
RocketChat:developfrom
amitkumarashutosh:fix/duplicate-toast-on-invite-link
Open

fix: Duplicate Toast Notification on Invite-Link#35345
amitkumarashutosh wants to merge 6 commits into
RocketChat:developfrom
amitkumarashutosh:fix/duplicate-toast-on-invite-link

Conversation

@amitkumarashutosh
Copy link
Copy Markdown
Contributor

@amitkumarashutosh amitkumarashutosh commented Feb 27, 2025

What does this PR do?

This PR fixes the issue where notifications were sent twice instead of once, ensuring proper notification behavior.

Video

Screen.Recording.2025-02-27.at.10.23.23.AM.mov

Issue(s)

#35335

Steps to test or reproduce

  1. Go to Home.
  2. Create a new channel.
  3. Inside the channel, click on the member icon at the top.
  4. Click on "Invite Link."

@amitkumarashutosh amitkumarashutosh requested a review from a team as a code owner February 27, 2025 05:17
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Feb 27, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: d11055d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@amitkumarashutosh amitkumarashutosh marked this pull request as draft February 27, 2025 15:01
@amitkumarashutosh amitkumarashutosh marked this pull request as ready for review February 27, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant