regression: fix regex error when sending multi-line code #35347
regression: fix regex error when sending multi-line code #35347kodiakhq[bot] merged 1 commit intorelease-7.4.0from
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
4ab0aa4 to
499eddb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.4.0 #35347 +/- ##
==============================================
Coverage 59.46% 59.46%
==============================================
Files 2830 2830
Lines 68627 68627
Branches 15181 15181
==============================================
Hits 40808 40808
Misses 25149 25149
Partials 2670 2670
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@abhinavkrin @MarcosSpessatto How do we make sure this doesn't happen again tomorrow when someone updates the minor dependencies? any test that could prevent that? |
Proposed changes (including videos or screenshots)
The issue was traced to the use of Unicode property escapes (
\p{S}and\p{P}) in the Haskell grammar definition ofhighlight.js, as detailed in highlight.js#4013.The issue only occurred in production, likely due to differences in how the build process handles regex.
So, I have rolled back to version
11.8.0as hotfix, which resolves the issue.Issue(s)
Steps to test or reproduce
Further comments
CORE-1005