Skip to content

fix: account profile page responsive behavior in lower size screen#35348

Open
ashbunnn wants to merge 50 commits into
RocketChat:developfrom
ashbunnn:fix/responsive-profile-page
Open

fix: account profile page responsive behavior in lower size screen#35348
ashbunnn wants to merge 50 commits into
RocketChat:developfrom
ashbunnn:fix/responsive-profile-page

Conversation

@ashbunnn
Copy link
Copy Markdown
Contributor

@ashbunnn ashbunnn commented Feb 27, 2025

Proposed changes (including videos or screenshots)

Before :
image
Screenshot 2025-02-27 at 15 56 42

After :
image
image

Issue(s)

#35349

Steps to test or reproduce

Open rocket.chat profile page via mobile browser

Further comments


This pull request addresses the responsive behavior of the account profile page in the Rocket.Chat repository. The changes focus on improving the layout for smaller screens. Specifically, the AccountProfileForm.tsx file has been refactored to adjust the layout of the email field and the 'Resend verification email' button using the useBreakpoints hook. This allows the flexDirection to switch between row and column based on the screen size, enhancing the form's responsiveness. Additionally, flexbox properties with a gap are used for better spacing. In the AccountProfilePage.tsx file, responsive design improvements are made by introducing breakpoint detection and grouping buttons vertically on mobile devices. These changes aim to enhance the user experience on lower size screens.

@ashbunnn ashbunnn requested a review from a team as a code owner February 27, 2025 10:38
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Feb 27, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 2c60617

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 27, 2025

CLA assistant check
All committers have signed the CLA.

@ashbunnn ashbunnn force-pushed the fix/responsive-profile-page branch 3 times, most recently from 8ea1a1c to 1b8d22d Compare February 27, 2025 17:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.38%. Comparing base (26461ca) to head (ce4d7a6).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35348      +/-   ##
===========================================
- Coverage    61.26%   60.38%   -0.89%     
===========================================
  Files         3164     2927     -237     
  Lines        74757    70334    -4423     
  Branches     16689    16157     -532     
===========================================
- Hits         45801    42468    -3333     
+ Misses       25850    24974     -876     
+ Partials      3106     2892     -214     
Flag Coverage Δ
e2e 56.15% <45.45%> (-1.87%) ⬇️
e2e-api 35.61% <ø> (-5.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ashbunnn ashbunnn force-pushed the fix/responsive-profile-page branch from 6d20555 to 1667cc8 Compare March 5, 2025 16:20
Comment thread apps/meteor/client/views/account/profile/AccountProfilePage.tsx Outdated
Comment thread apps/meteor/client/views/account/profile/AccountProfileForm.tsx Outdated
Comment thread apps/meteor/client/views/account/profile/AccountProfilePage.tsx Outdated
@ashbunnn ashbunnn changed the title fix: account profile page in lower size screen fix: account profile page responsive behavior in lower size screen Apr 13, 2025
@kody-ai
Copy link
Copy Markdown

kody-ai Bot commented Apr 20, 2025

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants