fix: Dropdown not closing when clicking outside and obstructing 'Create' button in Direct Message modal (#35375)#35376
Conversation
…e' button in Direct Message modal (RocketChat#35375)
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
@ggazzo Could you please assign the appropriate labels and milestone to this PR? Thanks! |
|
@Sing-Li could you please review this PR |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Closes #35375
Type: Bug
Description
This pull request fixes the issue where the dropdown in the 'Create Direct Message' modal does not close when clicking outside, and when there are many suggested users, it obstructs the 'Create' button.
Changes Made
Testing
Before
Watch the video preview: Google Drive Video
After
Watch the video preview: Google Drive Video
This pull request addresses an issue in the
UserAutoCompleteMultipleFederatedcomponent within the Rocket.Chat repository. The changes include enhancements to the dropdown functionality, specifically adding dynamic positioning to open upwards when there is limited space below. Additionally, the update introduces click-outside detection to ensure the dropdown closes when clicking outside of it, and a manual toggle for the dropdown direction. The internal logic for handling selected users has also been refactored. These improvements aim to resolve the problem of the dropdown not closing when clicking outside and obstructing the 'Create' button in the Direct Message modal. The changes are proposed from thefix-dropdown-issue-35375branch to thedevelopbranch.